-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -161,6 +159,25 @@ var _ = BeforeSuite(func() { | |||
"receiptsRoot": canonicalHeader.ReceiptHash, | |||
"totalDifficulty": (*hexutil.Big)(mockTD), | |||
} | |||
|
|||
// Insert some non-canonical data into the database so that we test our ability to discern canonicity | |||
// NOTE: Nan-canonical blocks must come first, because the statediffer will assume the most recent block it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo - Nan-canonical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need to reorder makes sense, LGTM!
Because the new indexer code will automatically flag pre-existing blocks as non-canonical when new block is added at the same height, I had to re-order the test setup to maek sure that non-canonical blocks are always added first.