Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 #252

Merged
merged 12 commits into from
Jul 31, 2023

Conversation

telackey
Copy link
Contributor

@telackey telackey commented Jul 21, 2023

Because the new indexer code will automatically flag pre-existing blocks as non-canonical when new block is added at the same height, I had to re-order the test setup to maek sure that non-canonical blocks are always added first.

@telackey telackey self-assigned this Jul 21, 2023
@telackey telackey changed the title WIP: 291 - Refactor SQL queries for latest schema. WIP: 251 - Refactor SQL queries for latest schema. Jul 21, 2023
@telackey telackey changed the title WIP: 251 - Refactor SQL queries for latest schema. Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 Jul 22, 2023
@telackey telackey changed the title Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 WIP: Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 Jul 22, 2023
@telackey telackey requested a review from roysc July 22, 2023 00:48
@telackey telackey marked this pull request as ready for review July 22, 2023 02:43
@telackey telackey changed the title WIP: Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 Update dependencies for ipld-eth-db 5.0.5 and geth v1.11.6-statediff-5.0.8 Jul 22, 2023
Copy link
Collaborator

@roysc roysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -161,6 +159,25 @@ var _ = BeforeSuite(func() {
"receiptsRoot": canonicalHeader.ReceiptHash,
"totalDifficulty": (*hexutil.Big)(mockTD),
}

// Insert some non-canonical data into the database so that we test our ability to discern canonicity
// NOTE: Nan-canonical blocks must come first, because the statediffer will assume the most recent block it is
Copy link
Collaborator

@roysc roysc Jul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - Nan-canonical

Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need to reorder makes sense, LGTM!

@telackey telackey merged commit 51c36ad into v5 Jul 31, 2023
5 checks passed
@telackey telackey deleted the telackey/291 branch July 31, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants