Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fixturenet-payments test #601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add fixturenet-payments test #601

wants to merge 2 commits into from

Conversation

iskay
Copy link
Collaborator

@iskay iskay commented Oct 24, 2023

dboreham
dboreham approved these changes Oct 24, 2023
View reviewed changes
.github/workflows/fixturenet-payments.yml Outdated
- name: "Build local shiv package"
run: ./scripts/build_shiv_package.sh
- name: "Run fixturenet-payments tests"
run: ./tests/fixturenet-payments/run-test.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a trailing newline please.

@dboreham
Copy link
Collaborator

There may be some issues with this test btw. The CI run above failed due to out of disk space. This is probably ok if it runs on gitea.

write /usr/local/share/.cache/yarn/v6/npm-@graphql-tools-mock-8.7.19-b6c01ecc44074a01d6f472213de5f56fe0a3380c-integrity/node_modules/@graphql-tools/mock/cjs/types.js: no space left on device

But in addition I see some errors in the nitro-ts container build that might be real problems. Possibly to do with using lerna?

@iskay
Copy link
Collaborator Author

iskay commented Oct 27, 2023

do you mean these lines in nitro-contracts and watcher-ts?

[3/4] Linking dependencies...
warning "workspace-aggregator-67870ab9-5229-47a3-9fa3-dffb535c9293 > @cerc-io/cache > [email protected]" has incorrect peer dependency "eslint@^7.12.1".
warning "workspace-aggregator-67870ab9-5229-47a3-9fa3-dffb535c9293 > @cerc-io/cache > [email protected]" has incorrect peer dependency "eslint@^7.0.0".

(and so on)

@dboreham
Copy link
Collaborator

do you mean these lines in nitro-contracts and watcher-ts?

[3/4] Linking dependencies...
warning "workspace-aggregator-67870ab9-5229-47a3-9fa3-dffb535c9293 > @cerc-io/cache > [email protected]" has incorrect peer dependency "eslint@^7.12.1".
warning "workspace-aggregator-67870ab9-5229-47a3-9fa3-dffb535c9293 > @cerc-io/cache > [email protected]" has incorrect peer dependency "eslint@^7.0.0".

(and so on)

No, those are normal JS babble.

do you mean these lines in nitro-contracts and watcher-ts?

[3/4] Linking dependencies...
warning "workspace-aggregator-67870ab9-5229-47a3-9fa3-dffb535c9293 > @cerc-io/cache > [email protected]" has incorrect peer dependency "eslint@^7.12.1".
warning "workspace-aggregator-67870ab9-5229-47a3-9fa3-dffb535c9293 > @cerc-io/cache > [email protected]" has incorrect peer dependency "eslint@^7.0.0".

(and so on)

No, that's normal JS-babble. Unfortunately I can't now find the errors in the latest job run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dboreham dboreham dboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iskay @dboreham