STOMP collector and output bots code: add security-related comments

certtools · Sep 14, 2023 · 25ca767 · 25ca767
1 parent 421fcaf
commit 25ca767
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/intelmq/bots/collectors/stomp/collector.py b/intelmq/bots/collectors/stomp/collector.py
@@ -93,7 +93,10 @@ def init(self):
             raise MissingDependencyError("stomp", version="4.1.8",
                                          installed=stomp.__version__)
 
+        # Note: the `ca_certs` SSL parameter must be set, otherwise the
+        # `stomp.py`'s machinery would disable certificate verification!
         ssl_params = dict(ca_certs=self.ssl_ca_certificate)
+
         conn_params = dict()
         if self.auth_by_ssl_client_certificate:
             ssl_params.update(

diff --git a/intelmq/bots/outputs/stomp/output.py b/intelmq/bots/outputs/stomp/output.py
@@ -44,7 +44,10 @@ def init(self):
             raise MissingDependencyError("stomp", version="4.1.8",
                                          installed=stomp.__version__)
 
+        # Note: the `ca_certs` SSL parameter must be set, otherwise the
+        # `stomp.py`'s machinery would disable certificate verification!
         ssl_params = dict(ca_certs=self.ssl_ca_certificate)
+
         conn_params = dict()
         if self.auth_by_ssl_client_certificate:
             ssl_params.update(