-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update API docs to work with rewritten API #2292
Conversation
Where can I see the code? :-) I was actually working on my own version of IntelMQ API using FastAPI... |
I opened PRs in the API repository in December: certtools/intelmq-api#38 (+depending PR 39 with packaging) |
@gethvi you can see the code in https://github.com/certtools/intelmq-api/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typo squatting suggestions.
May I suggest to run this through a spell checker again (use chatGPT or so and instruct it to rewrite it ;-) )
@aaronkaplan Done. The ChatGPT was unfortunately busy, but the LanguageTool found a few small issues |
Thank you very much! Looks great. |
fb6073e
to
0133c5f
Compare
Rewritten API requires configuring web server and services for manually installation. In addition, some previously missing information are clarified.
I rebased the branch on current develop to fix the conflict. @aaronkaplan This PR is marked by yourself as "changes requested". Please look to see if this PR is OK for you now. I think @kamil-certat addressed the issues you pointed out. |
Rewritten API requires configuring web server and services
for manually installation. In addition, some previously
missing information are clarified.
This docs are ready to review, but valid after merging the rewritten API in intelmq-api repository.