Added jamesbrine threat feed and parser #2396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added parser for jamesbrine.com.au threat feed
Added jamesbrine.com.au feed and parser reference
sebix
requested changes
Aug 22, 2023
Comment on lines
+7
to
+9
| import dateutil.parser | ||
| import posixpath | ||
| from urllib.parse import urlparse |
| """ | ||
|
|
||
| def parse_line(self, line, report): | ||
| if line.startswith('#') or len(line) == 0: |
|
|
||
| def parse_line(self, line, report): | ||
| if line.startswith('#') or len(line) == 0: | ||
| self.tempdata.append(line) |
There was a problem hiding this comment.
self.tempdata is never used. Did you intend to write your own recover_line method and using that one for raw?
There was a problem hiding this comment.
That was the intention. I've decided instead to adapt the csv endpoint instead such that a customer parser is not required and will be closing this PR.
sebix
added
feature
Co-authored-by: Sebastian <[email protected]>
|
CSV endpoint will be modified instead such that a custom parser is not required. PR will be closed and another opened when this has been completed and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
Added parser for jamesbrine threat feed
Added threat feed to feeds.yaml
Commit Messages
Changes detailed in commit messages. Added parser instead of generic_csv due to date field not including timestamp, parser adds 00:00UTC.
Description
Thanks