[cookie_manager] Fix FileSystemException when saving redirect cookies without a proper host
#1948
Conversation
…ctory, errno = 21)`
…ctory, errno = 21)`
…ctory, errno = 21)`
…th a full Uri for requests that had relative redirects
|
@ueman I've added a test. |
| } | ||
|
|
||
| void main() { | ||
| test( |
There was a problem hiding this comment.
Can you add a test that makes sure non relative redirects aren't modified?
I.e.: a redirect from example.org to sample.com should not write a cookie to example.org.
@kuhnroyal or @AlexV525 do you happen to know whether this is or can be a problem? I'm not really knowledgable in this area.
|
I was wondering if this should be resolved from the |
It doesn't look like a problem with the The |
| @@ -123,7 +123,9 @@ class CookieManager extends Interceptor { | |||
| // users will be available to handle cookies themselves. | |||
| final isRedirectRequest = statusCode >= 300 && statusCode < 400; | |||
| // Saving cookies for the original site. | |||
| await cookieJar.saveFromResponse(response.realUri, cookies); | |||
| final originalUri = response.requestOptions.uri; | |||
| final realUri = originalUri.resolveUri(response.realUri); | |||
There was a problem hiding this comment.
Do we have any standards that indicate we should resolve the real dest based on the original one?
There was a problem hiding this comment.
https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2
The field value consists of a single URI-reference. When it has the
form of a relative reference ([RFC3986], Section 4.2), the final
value is computed by resolving it against the effective request URI
([RFC3986], Section 5).
There was a problem hiding this comment.
Great. Could you add it as a comment, so we can track it back somedays if we forgot it.
Co-authored-by: Alex Li <[email protected]> Signed-off-by: Alex Isaienko <[email protected]>
AlexV525
changed the title
FileSystemException: Cannot open file ... (OS Error: Is a directory, errno = 21)FileSystemException when saving redirect cookies without a proper host
Upon relative redirect, cookies were not saved because the
hostwas missing.resolveUriprovides the proper host info for a redirect Uri in such cases and doesn't affect others.New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)