chore(pkg/cli): set default runner on linux to docker #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already the default runner under Darwin. And this is to provide consistency across different platforms, as Bubblewrap runner also runs with different uid in the userns and no capabilities, differently from both Docker and QEMU runners Signed-off-by: Massimiliano Giovagnoli <[email protected]>
xnox
pushed a commit
to wolfi-dev/os
that referenced
this pull request
Oct 29, 2024
Continuous integration and automation runs pipelines in Docker with Melange, in order to provide consistency and homogeneous environment, it sets the default runner to Docker. The Make variable can be inherited and overridden. Related: - chainguard-dev/melange#1611 Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker is already the default runner under Darwin. This is to provide consistency across different platforms, as Bubblewrap runner also runs with different uid in the userns and no capabilities, differently from both Docker and QEMU runners with root and a baseline set of capabilities.
Related:
Functional Changes
Notes:
To be verified.
SCA Changes
Notes:
To be verified.
Linter
Notes:
To be verified.