Bump apko, handle pointers #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
See chainguard-dev/apko#1453 Since GID is optional and 0 is a valid value, we needed a way to distinguish between unset and 0, so GID became a pointer. This broke the reflect code (labeled HACK) that punted on pointers. I've updated that code to handle pointers but also to ignore any fields marked with `apko:"experimental"` because I don't want to pollute the schema with them. Signed-off-by: Jon Johnson <[email protected]>
Closed
imjasonh
approved these changes
Dec 21, 2024
mattmoor
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stealing most of this from #434 but cleaned up the reflection code.