Let ghasum update fail if the gha.sum file is corrupt
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the internals for parsing the version from a gha.sum files in order to make `ghasum update` fail if the file is corrupted. This change is enforced going forward through the added test case.
Update the `ghasum update` CLI to accept a `-force` flag that can be used to force updating to ignore and fix any errors in the gha.sum file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Summary
Update the internals for parsing the version from a gha.sum files in order to make
ghasum updatefail if the file is corrupted. This change is enforced going forward through the added test case.TODO: Add option to
ghasum updateto force updategha.sumwhen it's corrupt.