Test and document behavior of sumfiles with duplicate entries #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcornelissen
added
bug
Add tests that verify the `ghasum update` and `ghasum verify` commands both reject sumfiles with duplicate (non-header) entries. Additionally test that `ghasum update -force` fixes duplicate (non-header) entries. To support this change some test re-organization was in order. The pre- existing "invalid sumfile" tests were specifically testing against a sumfile with a syntax error, hence these have been renamed (given the new tests are also for an "invalid sumfile"). Additionally, the implementation for sumfile parsing has been updated to improve the error messages produced, which are asserted in the new and changed tests. Similarly, the `SPECIFICATION.md` is updated to make explicit that duplicate sumfile entries should be rejected. As an aside, this uncovered a off-by-one bug in the line number formula in the implementation for sumfile parsing and corresponding incorrectly implemented unit test - both of which are fixed here.
Add tests that verify the `ghasum update` and `ghasum verify` commands both reject sumfiles with duplicate headers. To support this change some test re-organization was in order. The existing "Sumfile with ..." tests were specifically testing against problems with (non-header) entries but now there are (separate) tests for problems with headers and entries. Also, duplicate headers are unit tested for regardless of the sumfile version. The behavior of `ghasum update -force` is not covered here because there is currently no defined behavior for what `ghasum update` should do with headers. Additionally, the implementation for sumfile parsing has been updated to improve the error messages produced, which are asserted in the new and changed tests. Similarly, the `SPECIFICATION.md` is updated to make explicit that duplicate headers in a sumfile should be rejected. As an aside, this (also) uncovered a off-by-one bug in the line number formula in the implementation for sumfile header parsing which is fixed here as well.
ericcornelissen
force-pushed
the
32-duplicate-sumfile-entries
branch
from
ac1b345
to
15dca79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Summary
Add explicitly the expected behavior when a sumfile contains duplicate entries and test for this as well. This also fixes a related bug in the line number for syntax errors.