Basic cache eviction #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple and basic cache eviction strategy in order to avoid growing the cache indefinitely and to avoid validating against cache entries indefinitely (which may lead to false negatives). The current eviction strategy is to remove anything older than 5 days. Cache eviction happens in three scenarios. It happens when updating or verifying (unless the `-no-evict` flag is used, more on that below), or when explicitly using `ghasum cache evict`. Eviction is done at the repository level. That is, a cached repository will be evicted if it was cloned more than 5 days ago. Note that repos are cloned and stored on a per version basis, so the eviction should happen on, e.g., `actions/checkout/v5.0.0` (and not `actions/checkout`). Cache eviction can be disabled when updating or verifying to support use cases where eviction isn't desired. One example is when there is no internet connection. Another example is when validating in a CI pipeline (because we really want to validate with the runner put there, even if its timestamp indicates it's old).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Verify
Add a simple and basic cache eviction strategy in order to avoid growing the cache indefinitely and to avoid validating against cache entries indefinitely (which may lead to false negatives). The current eviction strategy is to remove anything older than 5 days.
Cache eviction happens in three scenarios. It happens when updating or verifying (unless the
-no-evictflag is used), or explicitly usingghasum cache evict.This implementation slightly extends the stated use case in #3 ("keeping the cache at a reasonable size"). The implementation here also considers the scenario where a cached entry prevents proper validation because the remote has been updated.