fix(postcss): race condition on builder instance for simultaneous plugin invocations #2919
+44
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8da1e6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
astahmer
reviewed
Oct 15, 2024
Comment on lines
+68
to
+78
| for (;;) { | ||
| if (!builderGuard) break | ||
| await builderGuard | ||
| } | ||
| const _builderGuard = postcssProcess(...args) | ||
| if (!_builderGuard) return | ||
|
|
||
| builderGuard = _builderGuard.finally(() => { | ||
| builderGuard = undefined | ||
| }) | ||
| return builderGuard |
There was a problem hiding this comment.
what is happening here ? I'm not familiar with this for (;;) trick
also, would it be possible to add a test somewhere in there https://github.com/chakra-ui/panda/blob/main/packages/postcss/__tests__/postcss.test.ts
|
Hi @doubleaxe, Do you think that PR will fix other issue "I don't see any styles" or it's not related at all ? https://panda-css.com/docs/installation/nextjs#i-dont-see-any-styles Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2916
📝 Description
Fixes postcss race condition because builder instance is singelton, and postcss plugin is async.
⛳️ Current behavior (updates)
Reported in bug report.
🚀 New behavior
Added
builderGuardwhich allow only one plugin invocation to be run at a time, other invocations will wait. Tested on my instance.💣 Is this a breaking change (Yes/No): No
📝 Additional Information