Enhance verbosity with detailed download progress information #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use yt_dlp's progress_hooks
|
@deldesir is this suggestion presumably related to... ? Explain a bit more the architectural/design context as to how/why this approach was chosen? |
|
@holta, this is indeed related to the ongoing effort in PR iiab/calibre-web#86. The reason behind this change is to enable efficient log polling for lines containing the specific information pattern "downloading xx%...". This is particularly valuable for scenarios where users or monitoring mechanisms need to track the progress of ongoing downloads. |
|
Thanks! looks good now with cf1a5f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses yt_dlp's progress_hooks to log information about percentage completed (
d['_percent_str']) and download speed (d['_speed_str']). This addition aims to provide more insights into the ongoing download process, assisting users or developers in monitoring and understanding the progress of the operation.