Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badge count to repo nav buttons to reflect number of issues. #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tammytee
Copy link
Contributor

Fixes issue #61

Looks like the open_issues_count also includes PRs in it's total. Assuming this is ok.

repo-btn-badge

@binarymason
Copy link
Member

Gah, I keep forgetting that GitHub's API considers PRs as issues.

Hmm from a UX perspective, including this number will only make sense if we include PR cards to the challenges page. Otherwise, it may be confusing. @hamholla what are your thoughts on this?

@binarymason
Copy link
Member

Ping @hamholla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants