Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/prop types #63

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

KingPra
Copy link
Contributor

@KingPra KingPra commented May 19, 2017

No description provided.

@kirillian
Copy link

This PR appears to be addressing #23

@KingPra
Copy link
Contributor Author

KingPra commented May 26, 2017

updated the "import PropTypes from "prop-types"

Copy link

@kirillian kirillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good other than some extra changes.

@@ -21,8 +21,12 @@ export const createSession = (googleOauthJWT) => {

return (dispatch) => {
axios(requestConfig)
.then(response => dispatch({ type: CREATE_SESSION, payload: response.data.user_info }))
.catch(error => dispatch({ type: NETWORK_ERROR, payload: error }));
.then((response) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KingPra These were changes made during debugging that you probably want to drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants