feat: add WindowTitle setting #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Aug 17, 2024
nixpig
force-pushed
the
set-window-title
branch
2 times, most recently
from
8b8572f
to
b01101b
Compare
nixpig
force-pushed
the
set-window-title
branch
from
b01101b
to
752b409
Compare
|
This broke the parser -- did you generate it with an older version of tree-sitter? Then you would have had to downgrade the headers, too. |
|
You really should set up workflows before you make any more changes... |
caarlos0
added a commit
that referenced
this pull request
Aug 24, 2024
I generated it using the version of tree-sitter specified in dependencies - 0.20.8. So, yeah, an older version of tree-sitter than was required. My bad. I was supposed to upgrade this at the same time as the tests. Apologies, and thank you for cleaning up the mess it caused 🤲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add grammar to parse
WindowTitlesetting. Per PR in vhs: charmbracelet/vhs#507