Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn when using SET commands not being the top decl #508

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Delta456
Copy link
Contributor

This PR adds a warning when using the SET commands after the top declaration.

Agreed, if a setting is ignored we should display a warning that this setting should appear at the top of the file!
Originally posted by @maaslalani in #503 (comment)

@bashbunni
Copy link
Member

Just tweaked the wording a bit. Thank you so much for the contribution :)
image

@bashbunni bashbunni merged commit 2ff7bbd into charmbracelet:main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants