This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat: use slurm snap for slurmrestd operations #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slurmrestd cannot run without this package installed, since it requires the libslurmfull.so file.
We don't really need to deploy against slurmd to check that slurmrestd works. This saves some CI time.
jedel1043
force-pushed
the
slurm-snap
branch
2 times, most recently
from
a5db983
to
f05fcd2
Compare
NucciTheBoss
suggested changes
Jul 26, 2024
src/constants.py
Outdated
Comment on lines
10
to
11
| SLURMRESTD_USER_NAME = "snap_daemon" | ||
| SLURMRESTD_GROUP_NAME = "snap_daemon" |
There was a problem hiding this comment.
Are these constants used anywhere anymore? A quick search seems to show that all references were removed when the deprecated methods were culled on the legacy operations manager.
NucciTheBoss
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the
slurm_opslibrary to manage slurmrestd.Adds support for running CI
How was the code tested?
Locally on an Ubuntu Noble development machine.
Checklist