Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle related methods #99

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jan 13, 2023

  1. Configuration menu
    Copy the full SHA
    b654f0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca57f22 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. bugfix: Fix deploy bundle method.

    Notes:
    * What was wrong?
    1. In `deploy_bundle`, I needed to convert the Path object for the bundle file to a string. If you do not convert to string first, Python will throw errors about trying to pass a Path object instead of a string to subprocess.
    2. In `render_bundle`, I needed to update the regex to allow files with just the extension .j2 and .tmpl instead of being prefixed with .yaml. If I did not do that, the function would try to perform string operations on the Path object which would throw type errors.
    NucciTheBoss committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    d53f1aa View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Update .gitignore

    addyess authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    3167964 View commit details
    Browse the repository at this point in the history