[LP#2039667] Provide charm config parameters on the default storage class #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
bug/LP2039667/parameters-to-default-storage-class
branch
from
78cc1ad
to
3c248fb
Compare
addyess
force-pushed
the
bug/LP2039667/parameters-to-default-storage-class
branch
from
8911ada
to
c743b0b
Compare
addyess
commented
Dec 15, 2023
addyess
commented
Dec 15, 2023
| @@ -217,7 +217,7 @@ def _install_or_upgrade(self, event, config_hash=None): | |||
| controller.apply_manifests() | |||
| except ManifestClientError as e: | |||
| self.unit.status = WaitingStatus("Waiting for kube-apiserver") | |||
| log.warn(f"Encountered retryable installation error: {e}") | |||
| log.warning(f"Encountered retryable installation error: {e}") | |||
There was a problem hiding this comment.
removes a deprecated method call
addyess
commented
Dec 15, 2023
| """Comparible based on its name.""" | ||
| """Comparable based on its name.""" |
mateoflorido
deleted the
bug/LP2039667/parameters-to-default-storage-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP#2039667
Allows the user to configure arbitrary parameters on the default storage class installed