Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookstyle Bot Auto Corrections with Cookstyle 7.13.0 #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cookstyle Bot Auto Corrections with Cookstyle 7.13.0 #22

wants to merge 1 commit into from

Conversation

cookstyle[bot]
Copy link

@cookstyle cookstyle bot commented Jun 18, 2021

This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.13.0). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.

Style/PercentLiteralDelimiters

Chef/Style/CommentFormat

Style/TrailingCommaInHashLiteral

  • /libraries/_junos_api_client.rb:41: Put a comma after the last item of a multiline hash.

Layout/IndentationConsistency

Layout/IndentationWidth

Lint/UnusedMethodArgument

Chef/Modernize/ResourceNameFromInitialize

Layout/DefEndAlignment

  • /libraries/_junos_api_client.rb:80: end at 80, 6 is not aligned with def at 72, 0.
  • /libraries/resource_group.rb:50: end at 50, 4 is not aligned with def at 37, 0.
  • /libraries/resource_interface.rb:53: end at 53, 4 is not aligned with def at 38, 0.
  • /libraries/resource_l2_interface.rb:51: end at 51, 4 is not aligned with def at 38, 0.
  • /libraries/resource_lag.rb:50: end at 50, 4 is not aligned with def at 38, 0.
  • /libraries/resource_vlan.rb:50: end at 50, 4 is not aligned with def at 38, 0.

Layout/RescueEnsureAlignment

  • /libraries/_junos_api_client.rb:147: rescue at 147, 8 is not aligned with begin at 145, 30.

Style/RedundantAssignment

  • /libraries/_junos_api_client.rb:220: Redundant assignment before returning detected.

Layout/EmptyLinesAroundMethodBody

Layout/EmptyLines

Layout/TrailingWhitespace

Chef/Style/UsePlatformHelpers

Chef/Modernize/WhyRunSupportedTrue

Chef/Modernize/DefaultActionFromInitialize

Layout/CommentIndentation

  • /libraries/resource_group.rb:40: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_group.rb:43: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_group.rb:48: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_interface.rb:41: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_interface.rb:44: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_interface.rb:51: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_l2_interface.rb:41: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_l2_interface.rb:44: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_l2_interface.rb:49: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_lag.rb:41: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_lag.rb:44: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_lag.rb:48: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_vlan.rb:41: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_vlan.rb:44: Incorrect indentation detected (column 10 instead of 6).
  • /libraries/resource_vlan.rb:48: Incorrect indentation detected (column 10 instead of 6).

Layout/EmptyLineBetweenDefs

Chef/Sharing/InvalidLicenseString

Chef/RedundantCode/LongDescriptionMetadata

Chef/Modernize/RespondToInMetadata

Style/ExpandPathArguments

  • /spec/spec_helper.rb:20: Use expand_path('support/**/*.rb', __dir__) instead of expand_path('../support/**/*.rb', __FILE__).
  • /spec/spec_helper.rb:25: Use expand_path('../libraries', __dir__) instead of expand_path('../../libraries', __FILE__).

Chef/Style/AttributeKeys

Style/StringLiterals

Signed-off-by: Cookstyle [email protected]

Cookstyle Bot Auto Corrections with Cookstyle 7.13.0
1c6b783 
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.13.0). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.

### Style/PercentLiteralDelimiters
  - **/Rakefile:27**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/libraries/_junos_api_client.rb:65**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/libraries/provider_group_junos.rb:77**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/libraries/resource_interface.rb:105**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/libraries/resource_interface.rb:120**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/libraries/resource_lag.rb:95**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/spec/unit/libraries/junos_api_client_spec.rb:55**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/spec/unit/provider/l2_interface/junos_spec.rb:26**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/spec/unit/provider/l2_interface/junos_spec.rb:34**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/spec/unit/provider/lag/junos_spec.rb:24**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/spec/unit/provider/lag/junos_spec.rb:33**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/test/fixtures/cookbooks/group/attributes/default.rb:1**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/test/fixtures/cookbooks/group/attributes/default.rb:1**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/test/fixtures/cookbooks/group/attributes/default.rb:1**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/test/fixtures/cookbooks/l2_interface/recipes/create.rb:20**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/test/fixtures/cookbooks/lag/recipes/create.rb:28**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)
  - **/test/integration/lag/serverspec/lag_create_spec.rb:7**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces)

### Chef/Style/CommentFormat
  - **/libraries/_helper.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/_junos_api_client.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/_junos_api_transaction_handler.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/_junos_api_transport.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/platform_provider_mapping.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_group_junos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_group_junos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_interface_eos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_interface_eos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_interface_junos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_interface_junos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_l2_interface_eos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_l2_interface_eos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_l2_interface_junos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_l2_interface_junos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_lag_eos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_lag_eos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_lag_junos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_lag_junos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_vlan_eos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_vlan_eos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_vlan_junos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/provider_vlan_junos.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_group.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_group.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_group.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_interface.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_interface.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_interface.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_l2_interface.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_l2_interface.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_l2_interface.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_lag.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_lag.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_lag.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_vlan.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_vlan.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/resource_vlan.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/spec_helper.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/support/shared_contexts/provider_junos.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/libraries/junos_api_client_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/libraries/junos_api_transport_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/provider/group/junos_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/provider/interface/junos_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/provider/l2_interface/junos_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/provider/lag/junos_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/spec/unit/provider/vlan/junos_spec.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/interface/recipes/create.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/interface/recipes/delete.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/l2_interface/recipes/create.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/l2_interface/recipes/delete.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/lag/recipes/create.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/lag/recipes/delete.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/vlan/recipes/create.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/test/fixtures/cookbooks/vlan/recipes/delete.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)

### Style/TrailingCommaInHashLiteral
  - **/libraries/_junos_api_client.rb:41**: Put a comma after the last item of a multiline hash.

### Layout/IndentationConsistency
  - **/libraries/_junos_api_client.rb:72**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/_junos_api_client.rb:72**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/_junos_api_client.rb:79**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/_junos_api_client.rb:150**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:35**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:35**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:37**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:37**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:41**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:44**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:46**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_group.rb:49**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:42**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:45**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:46**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:47**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:48**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:49**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_interface.rb:52**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:42**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:45**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:46**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:47**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_l2_interface.rb:50**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:42**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:45**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:46**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_lag.rb:49**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:36**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:38**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:42**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:45**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:46**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
  - **/libraries/resource_vlan.rb:49**: Inconsistent indentation detected. (https://rubystyle.guide#spaces-indentation, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)

### Layout/IndentationWidth
  - **/libraries/_junos_api_client.rb:72**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/_junos_api_client.rb:72**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/_junos_api_client.rb:73**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/_junos_api_client.rb:149**: Use 2 (not -20) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_group.rb:35**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_group.rb:35**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_group.rb:37**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_group.rb:37**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_group.rb:38**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_interface.rb:36**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_interface.rb:36**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_interface.rb:38**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_interface.rb:38**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_interface.rb:39**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_l2_interface.rb:36**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_l2_interface.rb:36**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_l2_interface.rb:38**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_l2_interface.rb:38**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_l2_interface.rb:39**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_lag.rb:36**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_lag.rb:36**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_lag.rb:38**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_lag.rb:38**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_lag.rb:39**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_vlan.rb:36**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_vlan.rb:36**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_vlan.rb:38**: Use 2 (not -2) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_vlan.rb:38**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  - **/libraries/resource_vlan.rb:39**: Use 2 (not 6) spaces for indentation. (https://rubystyle.guide#spaces-indentation)

### Lint/UnusedMethodArgument
  - **/libraries/_junos_api_client.rb:72**: Unused method argument - `resource_name`. If it's necessary, use `_` or `_resource_name` as an argument name to indicate that it won't be used. (https://rubystyle.guide#underscore-unused-vars)

### Chef/Modernize/ResourceNameFromInitialize
  - **/libraries/_junos_api_client.rb:78**: The name of a resource can be set with the "resource_name" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_resourcenamefrominitialize)
  - **/libraries/resource_group.rb:36**: The name of a resource can be set with the "resource_name" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_resourcenamefrominitialize)
  - **/libraries/resource_interface.rb:37**: The name of a resource can be set with the "resource_name" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_resourcenamefrominitialize)
  - **/libraries/resource_l2_interface.rb:37**: The name of a resource can be set with the "resource_name" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_resourcenamefrominitialize)
  - **/libraries/resource_lag.rb:37**: The name of a resource can be set with the "resource_name" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_resourcenamefrominitialize)
  - **/libraries/resource_vlan.rb:37**: The name of a resource can be set with the "resource_name" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_resourcenamefrominitialize)

### Layout/DefEndAlignment
  - **/libraries/_junos_api_client.rb:80**: `end` at 80, 6 is not aligned with `def` at 72, 0.
  - **/libraries/resource_group.rb:50**: `end` at 50, 4 is not aligned with `def` at 37, 0.
  - **/libraries/resource_interface.rb:53**: `end` at 53, 4 is not aligned with `def` at 38, 0.
  - **/libraries/resource_l2_interface.rb:51**: `end` at 51, 4 is not aligned with `def` at 38, 0.
  - **/libraries/resource_lag.rb:50**: `end` at 50, 4 is not aligned with `def` at 38, 0.
  - **/libraries/resource_vlan.rb:50**: `end` at 50, 4 is not aligned with `def` at 38, 0.

### Layout/RescueEnsureAlignment
  - **/libraries/_junos_api_client.rb:147**: `rescue` at 147, 8 is not aligned with `begin` at 145, 30.

### Style/RedundantAssignment
  - **/libraries/_junos_api_client.rb:220**: Redundant assignment before returning detected.

### Layout/EmptyLinesAroundMethodBody
  - **/libraries/_junos_api_client.rb:231**: Extra empty line detected at method body end. (https://rubystyle.guide#empty-lines-around-bodies)
  - **/libraries/_junos_api_client.rb:232**: Extra empty line detected at method body end. (https://rubystyle.guide#empty-lines-around-bodies)

### Layout/EmptyLines
  - **/libraries/_junos_api_client.rb:232**: Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines)

### Layout/TrailingWhitespace
  - **/libraries/_junos_api_client.rb:232**: Trailing whitespace detected. (https://rubystyle.guide#no-trailing-whitespace)

### Chef/Style/UsePlatformHelpers
  - **/libraries/_junos_api_transaction_handler.rb:34**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers)

### Chef/Modernize/WhyRunSupportedTrue
  - **/libraries/provider_group_junos.rb:34**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_interface_eos.rb:33**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_interface_junos.rb:34**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_l2_interface_eos.rb:33**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_l2_interface_junos.rb:34**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_lag_eos.rb:33**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_lag_junos.rb:34**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_vlan_eos.rb:33**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)
  - **/libraries/provider_vlan_junos.rb:34**: whyrun_supported? no longer needs to be set to true as it is the default in Chef Infra Client 13+ (https://docs.chef.io/workstation/cookstyle/chef_modernize_whyrunsupportedtrue)

### Chef/Modernize/DefaultActionFromInitialize
  - **/libraries/resource_group.rb:39**: The default action of a resource can be set with the "default_action" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_defaultactionfrominitialize)
  - **/libraries/resource_interface.rb:40**: The default action of a resource can be set with the "default_action" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_defaultactionfrominitialize)
  - **/libraries/resource_l2_interface.rb:40**: The default action of a resource can be set with the "default_action" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_defaultactionfrominitialize)
  - **/libraries/resource_lag.rb:40**: The default action of a resource can be set with the "default_action" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_defaultactionfrominitialize)
  - **/libraries/resource_vlan.rb:40**: The default action of a resource can be set with the "default_action" helper instead of using the initialize method. (https://docs.chef.io/workstation/cookstyle/chef_modernize_defaultactionfrominitialize)

### Layout/CommentIndentation
  - **/libraries/resource_group.rb:40**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_group.rb:43**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_group.rb:48**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_interface.rb:41**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_interface.rb:44**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_interface.rb:51**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_l2_interface.rb:41**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_l2_interface.rb:44**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_l2_interface.rb:49**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_lag.rb:41**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_lag.rb:44**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_lag.rb:48**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_vlan.rb:41**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_vlan.rb:44**: Incorrect indentation detected (column 10 instead of 6).
  - **/libraries/resource_vlan.rb:48**: Incorrect indentation detected (column 10 instead of 6).

### Layout/EmptyLineBetweenDefs
  - **/libraries/resource_group.rb:90**: Expected 1 empty line between class definitions; found 0. (https://rubystyle.guide#empty-lines-between-methods)

### Chef/Sharing/InvalidLicenseString
  - **/metadata.rb:4**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring)

### Chef/RedundantCode/LongDescriptionMetadata
  - **/metadata.rb:6**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata)

### Chef/Modernize/RespondToInMetadata
  - **/metadata.rb:9**: It is no longer necessary to use respond_to? or defined? in metadata.rb in Chef Infra Client 12.15 and later (https://docs.chef.io/workstation/cookstyle/chef_modernize_respondtoinmetadata)
  - **/metadata.rb:10**: It is no longer necessary to use respond_to? or defined? in metadata.rb in Chef Infra Client 12.15 and later (https://docs.chef.io/workstation/cookstyle/chef_modernize_respondtoinmetadata)

### Style/ExpandPathArguments
  - **/spec/spec_helper.rb:20**: Use `expand_path('support/**/*.rb', __dir__)` instead of `expand_path('../support/**/*.rb', __FILE__)`.
  - **/spec/spec_helper.rb:25**: Use `expand_path('../libraries', __dir__)` instead of `expand_path('../../libraries', __FILE__)`.

### Chef/Style/AttributeKeys
  - **/spec/unit/provider/group/junos_spec.rb:32**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/spec/unit/provider/group/junos_spec.rb:32**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/test/fixtures/cookbooks/group/recipes/bgp_create.rb:4**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/test/fixtures/cookbooks/group/recipes/bgp_create.rb:4**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/test/fixtures/cookbooks/group/recipes/service_create.rb:4**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/test/fixtures/cookbooks/group/recipes/service_create.rb:4**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/test/fixtures/cookbooks/group/recipes/syslog_create.rb:4**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)
  - **/test/fixtures/cookbooks/group/recipes/syslog_create.rb:4**: Use strings to access node attributes (https://docs.chef.io/workstation/cookstyle/chef_style_attributekeys)

### Style/StringLiterals
  - **/spec/unit/provider/group/junos_spec.rb:32**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/spec/unit/provider/group/junos_spec.rb:32**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/test/fixtures/cookbooks/group/recipes/bgp_create.rb:4**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/test/fixtures/cookbooks/group/recipes/bgp_create.rb:4**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/test/fixtures/cookbooks/group/recipes/service_create.rb:4**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/test/fixtures/cookbooks/group/recipes/service_create.rb:4**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/test/fixtures/cookbooks/group/recipes/syslog_create.rb:4**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  - **/test/fixtures/cookbooks/group/recipes/syslog_create.rb:4**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)

Signed-off-by: Cookstyle <[email protected]>
@cookstyle cookstyle bot mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants