License Caching and Add license enforcement to all APIs #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
|
Manual testing results |
|
|
Signed-off-by: jan shahid shaik <[email protected]>
marcparadise
reviewed
Oct 7, 2024
| "/_status" -> | ||
| {true, Req, State3}; | ||
| _ -> | ||
| case chef_license_worker:get_license() of |
There was a problem hiding this comment.
can we handle this case statement as a function, something like
_ ->
check_license(chef_license_worker:get_license(), Req, State3)
And:
check_license({valid_license..... }, Req, State ) ->
{ true, Req, State} ;
check_license({commercial_grace_period...
... etc
Makes it a little easier to test, and avoids deeply nesting the contents of service_available which makes it easier to parse.
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
|
|
|
Please find the below results: Working |
lbakerchef
approved these changes
Oct 8, 2024
sreepuramsudheer
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Please describe what this change achieves]
Implementation of license cache and changes in web machine to add license enforcement to all APIs
https://progresssoftware.atlassian.net/browse/CHEF-15863
https://progresssoftware.atlassian.net/browse/CHEF-12649
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List