feat: valid Pydantic

core/cat/db/crud.py

@@ -69,4 +69,7 @@ def upsert_setting_by_name(payload: models.Setting) -> models.Setting:
         query = Query()
         get_db().update(payload, query.name == payload.name)
 
-    return get_setting_by_name(payload.name)
+    return get_setting_by_name(payload.name)
+
+def validate_presences(required: list, payload: dict):
+    return len([req for req in required if req not in payload]) > 0

core/cat/routes/setting/embedder_setting.py

@@ -43,7 +43,7 @@ def get_embedder_settings():
 def upsert_embedder_setting(
     request: Request,
     languageEmbedderName: str,
-    payload: Dict = Body(example={"openai_api_key": "your-key-here"}),
+    payload: Dict = Body(..., example={"openai_api_key": "your-key-here"})
 ):
     """Upsert the Embedder setting"""
 
@@ -54,7 +54,17 @@ def upsert_embedder_setting(
             status_code=400,
             detail=f"{languageEmbedderName} not supported. Must be one of {allowed_configurations}",
         )
-
+
+    required = EMBEDDER_SCHEMAS[languageEmbedderName]['required']
+    if crud.validate_presences(required, payload):
+        raise HTTPException(
+            status_code=405,
+            detail={
+                "error": f"The following fields are required: {', '.join(required)}"
+            }
+        )
+
+
     # create the setting and upsert it
     final_setting = crud.upsert_setting_by_name(
         models.Setting(name=languageEmbedderName, category=EMBEDDER_CATEGORY, value=payload)

core/cat/routes/setting/llm_setting.py

@@ -45,7 +45,7 @@ def get_llm_settings():
 def upsert_llm_setting(
     request: Request,
     languageModelName: str,
-    payload: Dict = Body(example={"openai_api_key": "your-key-here"}),
+    payload: Dict = Body(..., example={"openai_api_key": "your-key-here"})
 ):
     """Upsert the Large Language Model setting"""
 
@@ -54,9 +54,22 @@ def upsert_llm_setting(
     if languageModelName not in allowed_configurations:
         raise HTTPException(
             status_code=400,
-            detail=f"{languageModelName} not supported. Must be one of {allowed_configurations}",
+            detail={
+                "error": f"{languageModelName} not supported. Must be one of {allowed_configurations}"
+            }
         )
-
+
+    # validate configuration
+    required = LLM_SCHEMAS[languageModelName]['required']
+    if crud.validate_presences(required, payload):
+        raise HTTPException(
+            status_code=405,
+            detail={
+                "error": f"The following fields are required: {', '.join(required)}"
+            }
+        )
+
+
     # create the setting and upsert it
     final_setting = crud.upsert_setting_by_name(
         models.Setting(name=languageModelName, category=LLM_CATEGORY, value=payload)

core/tests/routes/setting/test_llm_setting.py

@@ -36,4 +36,16 @@ def test_upsert_llm_settings_success(client):
     # assert
     assert response.status_code == 200
     assert json["selected_configuration"] == 'LLMCustomConfig'
-    assert json["settings"][0]["value"]["url"] == invented_url
+    assert json["settings"][0]["value"]["url"] == invented_url
+
+def test_upsert_llm_settings_error(client):
+
+    # set a different LLM
+    invented_url = "https://example.com"
+    payload = {}
+    response = client.put("/settings/llm/LLMCustomConfig", json=payload)
+    json = response.json()
+
+    # check immediate response
+    assert response.status_code == 405
+    assert json["detail"]["error"] == "The following fields are required: url"