Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints for LLM, Embedder and Plugin settings #399

Conversation

zAlweNy26
Copy link
Member

@zAlweNy26 zAlweNy26 commented Aug 4, 2023

Description

I added:

  • One endpoint for LLM settings to get the settings and schema of a specific LLM
  • One endpoint for Embedder settings to get the settings and schema of a specific Embedder
  • One endpoint for Plugin settings to get the list of all the settings and schemas of the available plugins

I also moved the endpoints to a more generic name, so that in future we can add other endpoints related to them.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@zAlweNy26 zAlweNy26 changed the base branch from main to develop August 4, 2023 14:36
@zAlweNy26 zAlweNy26 changed the title Other endpoints for LLM, Embedder and Plugin settings Endpoints for LLM, Embedder and Plugin settings Aug 4, 2023
async def wipe_conversation_history(

# DELETE memories
@router.delete("/{collection_id}/point/{memory_id}/")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieroit would you prefer like that or directly /{collection_id}/{memory_id}/ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave point, in the future we may consider other aspects of a collection as a resource

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, perfect!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the tests!!!
Going for /collections/{collection_id}/points/{memory_id}/ which should be the most RESTful

@pieroit
Copy link
Member

pieroit commented Aug 5, 2023

Closing this PR because I cannot rebase it to branch zAlweNy26-specific_llm-embedder-plugin_settings

Your commits are saved and part of the history as you can see here, so they will end up in develop and then main.

Thanks 👯

@pieroit pieroit closed this Aug 5, 2023
@zAlweNy26 zAlweNy26 deleted the specific_llm-embedder-plugin_settings branch August 28, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants