-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoints for LLM, Embedder and Plugin settings #399
Endpoints for LLM, Embedder and Plugin settings #399
Conversation
async def wipe_conversation_history( | ||
|
||
# DELETE memories | ||
@router.delete("/{collection_id}/point/{memory_id}/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pieroit would you prefer like that or directly /{collection_id}/{memory_id}/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's leave point
, in the future we may consider other aspects of a collection as a resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the tests!!!
Going for /collections/{collection_id}/points/{memory_id}/
which should be the most RESTful
Closing this PR because I cannot rebase it to branch Your commits are saved and part of the history as you can see here, so they will end up in Thanks 👯 |
Description
I added:
I also moved the endpoints to a more generic name, so that in future we can add other endpoints related to them.
Type of change
Checklist: