Fixed LLMCustom setup
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rabbithole: progress percentages + bug fixes on URL ingestion
Update README.md
pieroit
reviewed
Aug 18, 2023
core/cat/factory/llm.py
Outdated
| @@ -46,7 +46,7 @@ class LLMCustomConfig(LLMSettings): | |||
| @classmethod | |||
| def get_llm_from_config(cls, config): | |||
| # options are inserted as a string in the admin | |||
| if type(config["options"]) == str: | |||
| if isinstance(config["options"], dict): | |||
There was a problem hiding this comment.
Here we were checking for a string because there is a free text input box in the admin (where people can write a doctionary). That dictionary is later parsed with json.loads
There was a problem hiding this comment.
Ah I've misunderstood that, I'm correcting it.
Also, I think I've slipped and branched out main rather than develop. It's better if I open a new PR, isn't it?
There was a problem hiding this comment.
They should be aligned apart from the readme, don't worry in this case nothing happened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of issues related to using a custom LLM.
Type of change
Checklist: