Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to documentation in Custom LLM description #425

Merged

Conversation

nicola-corbellini
Copy link
Member

Description

I added a link key to the LLMCustomConfig schema so @zAlweNy26 can point the user to the tutorial on the website.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@nicola-corbellini
Copy link
Member Author

to keep schemas consistent what about adding a link to the vendor's pages for the others LLM options? Otherwise I can close this PR, it is not crucial having a link to the website

@pieroit pieroit merged commit 7b65023 into cheshire-cat-ai:develop Aug 21, 2023
2 checks passed
@pieroit
Copy link
Member

pieroit commented Aug 21, 2023

to keep schemas consistent what about adding a link to the vendor's pages for the others LLM options? Otherwise I can close this PR, it is not crucial having a link to the website

Yes it has to be consistent to avoid spaghetti solutions, but this seems a good one to me.

@nicola-corbellini
Copy link
Member Author

nicola-corbellini commented Aug 21, 2023

@zAlweNy26 is not happy of this 😂
@pieroit ok I'll open a new pr with the other links then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants