Check plugin activation error #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieroit
reviewed
Aug 24, 2023
| @@ -48,15 +50,28 @@ def __init__(self, plugin_path: str, active: bool): | |||
|
|
|||
| # all plugins start active, they can be deactivated/reactivated from endpoint | |||
| if active: | |||
| self.activate() | |||
| try: | |||
There was a problem hiding this comment.
is this necessary? Having already a try/except in the /plugins/toggle/ endpoint and inside self._load_hooks_and_tools?
| for py_file in self.py_files: | ||
| py_filename = py_file.replace("/", ".").replace(".py", "") # this is UGLY I know. I'm sorry | ||
| log(f"Remove module {py_filename}", "DEBUG") | ||
| sys.modules.pop(py_filename) |
|
@Pingdred I'm having difficulties undesrstanding where the try/except blocks are necessary and where they are not. |
|
Sure, I'll ping you on discord later 😄 |
|
Thanks <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check if there is an error activating the plugin and if so, return HTTP 500.
Also plugin modules are "unimported" when it is disabled.
Type of change
Checklist: