Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin object not active by default #433

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Plugin object not active by default #433

merged 8 commits into from
Sep 1, 2023

Conversation

Pingdred
Copy link
Member

Description

A Plugin object is now create not active by default, the manifest is loaded but no modules are imported.
Aligned also tests and the MadHatter.

A newly installed plugin is still activated by default, this PR does not change the behavior of the MadHatter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

core/cat/mad_hatter/plugin.py Show resolved Hide resolved
core/tests/mad_hatter/test_plugin.py Show resolved Hide resolved
@Pingdred
Copy link
Member Author

I put the tests on hooks and tools that were previously in test_create_active_plugin into test_activate_plugin, plus some little edit to use the plugin fixture. Let me know what you think.

@Pingdred Pingdred requested a review from pieroit August 30, 2023 14:46
@pieroit pieroit merged commit b45821a into cheshire-cat-ai:develop Sep 1, 2023
2 checks passed
@Pingdred Pingdred deleted the plugin_refactoring branch November 2, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants