Refactored WS messages functionality #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zAlweNy26
commented
Aug 29, 2023
| @@ -217,36 +217,19 @@ def file_to_docs( | |||
| blob = Blob(data=file_bytes, | |||
| mimetype=content_type, | |||
| source=source).from_data(data=file_bytes, | |||
| mime_type=content_type) | |||
| mime_type=content_type, | |||
| path=source) | |||
There was a problem hiding this comment.
Please don't kill me Piero I know it's not related to the PR, but I also added the path here because it doesn't arrive any source to the parsers. As the documentation says, path will set the source of the Blob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think I improved the way to send ws messages, so that if in the future it should change, we only have to change that specific function. In this way also it's easier for plugins to send directly messages to the chat without waiting for a user input that triggers the tool each time.
Type of change
Checklist: