Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ws content sent on error #447

Merged

Conversation

zAlweNy26
Copy link
Member

Description

As discussed in the past with @pieroit, I updated the content to send to the frontend when an error shows up, and also added the possibility to send an error via ws within a plugin.
I also fixed #434 as it was just 2 lines of code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit pieroit merged commit 64d845f into cheshire-cat-ai:develop Sep 4, 2023
2 checks passed
@zAlweNy26 zAlweNy26 deleted the updated-ws-error-message-fixed-434 branch September 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants