Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in memory collections' snapshopts #466

Merged

Conversation

nicola-corbellini
Copy link
Member

Description

Now, saving the vector memory collections' snapshots is optional.
Default behavior is saving the snapshots, but this can be turned off setting SAVE_MEMORY_SNAPSHOTS=false in the .env file.

Related to issue #463

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit
Copy link
Member

pieroit commented Sep 27, 2023

Sorry for checking this only now... would you mind to make it the opposite?
Opt-in = turned off by default, user activates
Opt-out = turned on by default, use deactivates

@nicola-corbellini
Copy link
Member Author

Yep, done. Default is now false

@pieroit pieroit merged commit fdd2228 into cheshire-cat-ai:develop Sep 27, 2023
1 check passed
@nicola-corbellini nicola-corbellini deleted the feature/optin_snapshopts branch September 27, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants