Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent naming for path and url strings #472

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

rojin254
Copy link
Contributor

Description

Changed the url strings in get_static_url method and get_base_url method to have a trailing "/" ( static/ instead of /static) to make it consistent with other url and path returning methods

Related to issue #469

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit pieroit merged commit d5e17ea into cheshire-cat-ai:develop Sep 28, 2023
1 check passed
@pieroit
Copy link
Member

pieroit commented Sep 28, 2023

Thanks and welcome @rojin254
Why don't you jump in the discord

@rojin254 rojin254 deleted the fix/consistent-path-naming branch September 28, 2023 14:47
@rojin254 rojin254 restored the fix/consistent-path-naming branch September 28, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants