Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cat.ws_messages an async queue #481

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Make cat.ws_messages an async queue #481

merged 1 commit into from
Oct 14, 2023

Conversation

Pingdred
Copy link
Member

Description

I made the cat.ws_messages an an asynchronous queue, so the check_messages function doesn't need to check if there are messages in the queue and send them every QUEUE_CHECK_INTERVAL seconds but sends messages as soon as they are queued.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit
Copy link
Member

pieroit commented Oct 11, 2023

Hard core

I probably need an explanation :D

@Pingdred
Copy link
Member Author

Hard core

I probably need an explanation :D

If you want tomorrow I'm free

@pieroit pieroit merged commit 967f6e6 into cheshire-cat-ai:develop Oct 14, 2023
1 check passed
@Pingdred Pingdred deleted the Async-ws-messages-queue branch October 16, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants