Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cat as singleton #520

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Cat as singleton #520

merged 3 commits into from
Oct 23, 2023

Conversation

zAlweNy26
Copy link
Member

Description

As discussed in the related issue, the CheshireCat class should be a singleton.

Related to issue #443

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@nicola-corbellini
Copy link
Member

Chapeau

@zAlweNy26
Copy link
Member Author

@nicola-corbellini for some reason the tests are failing

@pieroit
Copy link
Member

pieroit commented Oct 23, 2023

The adventure begins

@pieroit pieroit merged commit 8dadb46 into cheshire-cat-ai:develop Oct 23, 2023
1 check failed
@zAlweNy26 zAlweNy26 deleted the cat_as_singleton branch October 23, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zAlweNy26 @nicola-corbellini @pieroit