Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDIT: plugin installation endpoints sync #600

Merged
merged 1 commit into from
Dec 4, 2023
Merged

EDIT: plugin installation endpoints sync #600

merged 1 commit into from
Dec 4, 2023

Conversation

kodaline
Copy link
Contributor

@kodaline kodaline commented Dec 3, 2023

Description

Plugin endpoints for installation from both registry and zip are now sync, not using BackgroundTasks anymore.

Related to issue #451

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kodaline
edit: plugins install endpoints
d9ec2f4 
- plugin install from registry and via zip now do not use background
task to make the job
@kodaline kodaline changed the title plugin installation endpoints now sync EDIT: plugin installation endpoints sync Dec 3, 2023
@pieroit pieroit merged commit 869eb75 into cheshire-cat-ai:develop Dec 4, 2023
1 check passed
@kodaline kodaline deleted the develop_sync_endpoints branch January 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kodaline @pieroit