Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload one chunk #744

Closed
wants to merge 3 commits into from
Closed

Conversation

steeeee99
Copy link

@steeeee99 steeeee99 commented Mar 11, 2024

Description

Added a new endpoint to upload and store just one chunk of text.

Related to issue #716

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@zAlweNy26
Copy link
Member

zAlweNy26 commented Mar 11, 2024

What is the benefit of this instead of just creating a file on the fly and sending it through the existing endpoint?

@pieroit
Copy link
Member

pieroit commented Mar 11, 2024

What is the benefit of this instead of just creating a file on the fly and sending it through the existing endpoint?

I opened an issue for this feat
Just text plus metadata, so any other parsing and splitting can be done client side

@pieroit
Copy link
Member

pieroit commented Mar 11, 2024

@steeeee99 thanks, reviewing soon

chunk: str = Body(
description="A chunk to upload in the cat memory",
examples={"Example of chunk with length greater than 20"},
min_length=20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any particular reason for the choice of 20?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no particular reason, what value is best to have? 10 like here ?

@steeeee99
Copy link
Author

What is the benefit of this instead of just creating a file on the fly and sending it through the existing endpoint?

I opened an issue for this feat Just text plus metadata, so any other parsing and splitting can be done client side

Hey @pieroit, I'm uploading only a string, we need also metadata ? with which fields?

@pieroit
Copy link
Member

pieroit commented Mar 18, 2024

What is the benefit of this instead of just creating a file on the fly and sending it through the existing endpoint?

I opened an issue for this feat Just text plus metadata, so any other parsing and splitting can be done client side

Hey @pieroit, I'm uploading only a string, we need also metadata ? with which fields?

Hi @steeeee99,
thanks for this contribution.

metadata should be a dictionary, containing anything (because metadata is custom)
Here is how we fill up default metadata.

@pieroit
Copy link
Member

pieroit commented Mar 25, 2024

@steeeee99 any progress on this?
Please remake the PR branching off develop and towards develop, main is just for releases

@pieroit
Copy link
Member

pieroit commented May 5, 2024

Closing as this feat should be made according to #764 and not related to the rabbit hole

@pieroit pieroit closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants