Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form in intermediate steps #833

Merged
merged 1 commit into from
May 24, 2024

Conversation

Pingdred
Copy link
Member

Description

  • Factorized execute_procedures_agent to better readability.
  • Added Form in intermediate steps and why

Related to issue #719

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

- Factorized code to better readability.
- Added Form in intermediate steps and why
@valentimarco
Copy link
Collaborator

i don't like the function declaration, isn't possible to move most of the function outside?

@Pingdred
Copy link
Member Author

i don't like the function declaration, isn't possible to move most of the function outside?

Sure, I just wanted to split the code, we can definitely find a better place to put them

@pieroit
Copy link
Member

pieroit commented May 24, 2024

It is way more readable now! Kudos @Pingdred
Agree with @valentimarco moving the functions outside can be useful
Merging

@pieroit pieroit merged commit 74c03ae into cheshire-cat-ai:develop May 24, 2024
1 check passed
@Pingdred Pingdred deleted the form_in_interm_steps branch November 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants