Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add recall method #883

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add recall method #883

wants to merge 1 commit into from

Conversation

nicola-corbellini
Copy link
Member

Description

I'm opening a new PR 'cause I've messed up the commit history in the previous one #848.

I've implemented the requested changes and some tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AlessandroSpallina
Copy link
Member

is this PR still valid?

@pieroit
Copy link
Member

pieroit commented Oct 13, 2024

is this PR still valid?

Yes, needs a couple of tweaks but it is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieroit pieroit Awaiting requested review from pieroit

Assignees
No one assigned
Labels
memory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicola-corbellini @AlessandroSpallina @pieroit @valentimarco