Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup process twice #938

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

sambarza
Copy link
Contributor

@sambarza sambarza commented Oct 7, 2024

Description

The initialization process that create cheshire_cat_api is called twice.
Uvicorn.run with the reload options true, run main.py again.
Moved the initialization tasks in new startup.py file.

Related to issue #935

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

The initialization process that create cheshire_cat_api is called twice

Uvicorn.run with the reload options true, run main.py again

Moved the the initialization tasks in new startup.py file
@pieroit
Copy link
Member

pieroit commented Nov 1, 2024

Thanks @sambarza, crazy nobody realized this until now XD

@pieroit pieroit merged commit 82da8ee into cheshire-cat-ai:develop Nov 1, 2024
2 checks passed
@sambarza sambarza deleted the startup-process-twice branch November 1, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants