Do not remove the session manually #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of the session is already handled centrally. Closing of a sessions raises the exception WebSocketDisconnect that is already handled in websocket.websocket_endpoint More, removing the session here from the stray, could hide possible unknown. For now I suggest to not remove the session, this can help to spots others unknown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Session handling is already managed centrally. Closing a session raises the WebSocketDisconnect exception, which is already handled in websocket.websocket_endpoint.
Additionally, removing the session here could obscure potential issues. For now, I suggest not removing the session, as this can help identify other unknowns.
Related to issue #915 and pull request #936
Type of change
Checklist: