Do not start the container manually during tests action #940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We start the container just to run the tests however the launched instance is not used by the tests, FastAPI's
TestClient
doesn't need the Cat to be running; it starts the Cat instance on its own for each individual test.Removed the up and down steps.
This should also speed up the tests step too.
Using
docker exec
instead ofdocker run
becauseexec
needs an already running container, whilerun
creates the container before starting the command.docker run
need the service name instead of the container name.Not related to issue.
Type of change
Checklist: