Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added anthropic as supported llm provider #963

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

lucagobbi
Copy link
Collaborator

Description

This PR to add Anthropic as LLM provider. Since we support OpenAI, Cohere and Gemini I thought it was a little bit racist to exclude Anthropic outright.

I removed an old dependency anthropic==0.2.9, honestly idk what purpose it served since Anthropic wasn't supported.
As mentioned in #952, we may need a langchain update, that's why I was forced to use langchain-anthropic==0.1.23 even if the latest is 0.2.4, time to make some updates.

Anthropic doesn't offer its own embedding models as they say here, they have a strong relationship with Voyage AI, should we support them among the other embedders?

Related to issue #961

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@valentimarco
Copy link
Collaborator

Anthropic doesn't offer its own embedding models as they say here, they have a strong relationship with Voyage AI, should we support them among the other embedders?

Yes but do not put as automatic embedder when selecting the model. We should remove that feature...
If you add this and fix the linting, i can merge it

@pieroit
Copy link
Member

pieroit commented Nov 1, 2024

Thanks @lucagobbi awesome
Agree time to update langchain, but last time I tried I cried

@valentimarco is right we'll take away the automatic sync between LLM and embedders*, so just Anthropic LLM is just fine.

*Need to refactor vector memory a little so when one switches embedders collections are not deleted; once that is done embedder setting is not automatic, user gets notifified via chat in the same way he/she is notified about the LLM

@pieroit pieroit merged commit 4129d19 into cheshire-cat-ai:develop Nov 1, 2024
1 of 2 checks passed
@lucagobbi
Copy link
Collaborator Author

@pieroit I'd like to use Voyage AI for some stuff, as I understand correctly you wouldnt add it as supported by default, is it correct? If yes, I'll create a plugin for that. If not, I can add the default factory. Thankss

@pieroit
Copy link
Member

pieroit commented Nov 6, 2024

@pieroit I'd like to use Voyage AI for some stuff, as I understand correctly you wouldnt add it as supported by default, is it correct? If yes, I'll create a plugin for that. If not, I can add the default factory. Thankss

Yep go for a plugin please
Let's keep as "core included" only the top names (open and closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants