Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue #980 #982

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

giuseppe-coco
Copy link

Related to issue #980

Checklist:

  • Tests

@giuseppe-coco
Copy link
Author

Hi, I fixed the error

Copy link

@matteocacciola matteocacciola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take care about

for hook in self.plugins[plugin_id]._plugin_overrides:
and
for hook in self.plugins[plugin_id]._plugin_overrides:

core/cat/mad_hatter/plugin.py Outdated Show resolved Hide resolved
core/cat/mad_hatter/mad_hatter.py Outdated Show resolved Hide resolved
core/cat/mad_hatter/mad_hatter.py Outdated Show resolved Hide resolved
@giuseppe-coco
Copy link
Author

from the develop branch, from which I created the branch for issue#980, neither cat nor pytest can be launched, due to the error: ModuleNotFoundError: No module named ‘langchain_anthropic’.
This is why the development of this simple enhancement is becoming time-consuming 😕

@pieroit
Copy link
Member

pieroit commented Dec 6, 2024

from the develop branch, from which I created the branch for issue#980, neither cat nor pytest can be launched, due to the error: ModuleNotFoundError: No module named ‘langchain_anthropic’. This is why the development of this simple enhancement is becoming time-consuming 😕

why is Anthropic needed here?
BTW should be supported natively in develop

@giuseppe-coco
Copy link
Author

hi, is there anything else that needs to be done for this PR?

@pieroit
Copy link
Member

pieroit commented Dec 8, 2024

hi, is there anything else that needs to be done for this PR?

No, just wait I'll review soon
Thansk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants