Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: bad location was displayed in assigned events tab/rtticketvie… #2476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −17
Open

bugfix: bad location was displayed in assigned events tab/rtticketvie… #2476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions lib/LMSManagers/LMSHelpdeskManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,24 +760,15 @@ public function GetQueueNameByTicketId($id)

public function GetEventsByTicketId($id)
{
$events = $this->db->GetAll('SELECT events.id as id, title, description, note, date, begintime, endtime, '
. 'userid, customerid, private, closed, closeddate, closeduserid, events.type, ticketid, va.location, '
. $this->db->Concat('customers.lastname', "' '", 'customers.name').' AS customername, '
. $this->db->Concat('users.firstname', "' '", 'users.lastname').' AS username, '
. $this->db->Concat('u.firstname', "' '", 'u.lastname').' AS closedusername, vn.name AS node_name, '
. $this->db->Concat('c.city', "', '", 'c.address') . ' AS customerlocation, vn.location AS node_location '
. 'FROM events '
. 'LEFT JOIN customers ON (customerid = customers.id) '
. 'LEFT JOIN users ON (userid = users.id) '
. 'LEFT JOIN users u ON (closeduserid = u.id) '
. 'LEFT JOIN vaddresses va ON va.id = events.address_id '
. 'LEFT JOIN vnodes as vn ON (nodeid = vn.id) '
. 'LEFT JOIN customerview c ON (events.customerid = c.id) '
. 'WHERE ticketid = ? ORDER BY events.id ASC', array($id));

if (is_array($events)) {
$event_manager = new LMSEventManager($this->db, $this->auth, $this->cache);
$events = $this->db->GetAll(
'SELECT id FROM events WHERE ticketid = ? ORDER BY id ASC',
array($id)
);

if (!empty($events)) {
foreach ($events as $idx => $row) {
$events[$idx]['userlist'] = $this->db->GetAll("SELECT vu.name,userid AS ul FROM eventassignments AS e LEFT JOIN vusers vu ON vu.id = e.userid WHERE eventid = $row[id]");
$events[$idx] = $event_manager->GetEvent($row);
}
}

Expand Down