New feature: add MERGE_COMMENT option #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarch
commented
Oct 24, 2022
| const error = e as Error; | ||
|
|
||
| ghCore.error( | ||
| `Unable to merge pull request #${prNumber}. Could be because the PR doesn't exist, or the token lacks write permissions for the repo. Error was: ${error.message}`, |
There was a problem hiding this comment.
We encountered this "Not found" issue when configuring the action and using a token that only had read access for the repo. It doesn't need to be part of this PR of course if you prefer keeping it separate or not including it
This occurs for us as the merge queue protects the branch of the PR.
Loads of tests will go through this path now and fail, so I'm just going to hack in a mock to bypass the new condition.
…cted-branch INFRA-1996 Skip PRs where the head branch is protected
* INFRA-1996 Persist get branch mock * INFRA-1996 Add a test for head branch being protected * INFRA-1996 Rename branch vars * INFRA-1996 Catch protected branch error and exit cleanly I think there could be a race condition where PRs are queued after the method has started. So I'm capturing the error at the end and just exiting out. * INFRA-1996 Add some debug logging * yarn run lint:fix * Add pre-commit-config.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we forked this action because of a use-case where we needed a comment to be added to Pull Requests after the autoupdate merge has occurred
(It allowed us to trigger the actions of a github bot that looks for the content of comments on Pull Requests)
This might be something you would consider adding upstream