Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Passive" to "Simplex" [RFC] #36

Open
mwachs5 opened this issue Aug 10, 2022 · 0 comments
Open

Rename "Passive" to "Simplex" [RFC] #36

mwachs5 opened this issue Aug 10, 2022 · 0 comments

Comments

@mwachs5
Copy link
Collaborator

mwachs5 commented Aug 10, 2022

The FIRRTL spec names types that all have the same direction with no flipped-ness as "passive" (https://github.com/chipsalliance/firrtl-spec/blob/e7199fcc219bbc6e8bf9f380dc15dcdac20961c2/spec.md#passive-types). In other words this is the opposite of "Duplex". In english "Passive" and "Duplex" do not seem like intuitive opposites. Would "Simplex" Be a better term? Or is there some implied meaning of "Active vs Passive", but "Active" does not appear in the spec except in the context of read/write ports which seems like a very different concern,

Duplex is currently defined in contrast with "sink" and "source" for Flows, so not sure if this is an appropriate substitution of saying "anything not sipmlex is duplex" since passive is talking about the type not the particular hardware (Node, reg, port, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant