Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI #329

Merged
merged 4 commits into from
Jul 7, 2021
Merged

Fix failing CI #329

merged 4 commits into from
Jul 7, 2021

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented Jul 5, 2021

CI was failing in two ways:

  1. nextpnr-xilinx is currently not up to date with the latest prjxray-db and it was failing on bitstream generation, and it is causing nightly build failures. This PR removes nextpnr-xilinx from the mandatory list of toolchains that are required to pass to have a successful build.
  2. some feature tests (e.g. parameter swapping) were allowed to pass even though a failure was present. This PR makes it mandatory to have those tests passing as well.

Also, this PR fixes #328, so that it is clear that some tests are allowed to fail as CI runs all possible toolchain-project-board combinations, and not all the combinations are successful. "True failures" do instead cause the CI build to fail.

@acomodi
Copy link
Contributor Author

acomodi commented Jul 5, 2021

@mithro @tcal-x Kokoro CI failed without a log. Is it possible to get the log from somewhere to understand what is going on?

@tcal-x
Copy link
Contributor

tcal-x commented Jul 7, 2021 via email

@acomodi acomodi merged commit 9f58507 into chipsalliance:master Jul 7, 2021
@umarcor umarcor deleted the fix-ci branch April 21, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is broken in a number of ways?
2 participants