fix: resolve links when getting MATCHED_FG highlight

[bi0ha2ard]

My colorscheme sets WarningMsg as a link, so nvim_get_hl would just return the link object, for which fgwould be nil. This would break all select UIs with an error when nil is passed to string.format.

For reference: The output of nvim_get_hl:

{
  link = "GruvboxRedBold"
}

With this fix, it returns the actual highlight, including the foreground color. That resolves the issue.

[chipsenkbeil]

@bi0ha2ard thanks for catching this! One of the areas I lack experience in with neovim plugin development is highlight groups. Should normal_hl and selected_hl also use link = false?

[bi0ha2ard]

TBH I jus tlooked at the help and saw that there's an option to follow the link, so I'm not an expert either.

That being said, with link = true you will create { link = "Something, fg = "#abcdef" }. I don't know if that's vaild.

Using link = false will probably do what you wanted, i.e. create a highlight based on the original with replaced colors.

[chipsenkbeil]

@bi0ha2ard cool. I'll merge this in and then play around with tweaking the other colors. Thanks again for the find and fix!