(#854) Update to contributing.md #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
requested changes
May 26, 2021
|
@KrisBierma thanks again for taking the time to submit this PR, really appreciate it! I have left a couple of comments for some changes. Can I also ask that you tag the issue in the commit message? i.e. rather than having: use: Also, as mentioned in the doc, can you wrap the main body of the commit message at 72 characters? Thanks again! |
KrisBierma
force-pushed
the
contributing_md
branch
from
eb48ea4
to
5ffb957
Compare
KrisBierma
changed the title
|
@KrisBierma thank you very much for getting this updated! Really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dead and inactive links updated to help new devs sign the agreement and
communicate about issues. Git commands added and some sentences
reworded for clarity.
Issue #854