Fix positioning bug on relative elements #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, as you can see, I'm way behind on following up on any of my OSS libraries. I'll put this on the agenda! Thanks for putting a PR together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basically the outer span (the original tlite) is given a width and this serves as a max-width for the new inner span. Doing it this way solves the positioning problem. All the positioning css remains on the tlite class, while the visual styling is moved to the inner class; that's all that changed mainly. I admit it may be a bit "hacky" but it does the trick and I haven't found any drawback yet.
If you don't like that's fine too, feel free to ditch this then :)